Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct docstrings for integer division and modulus #5230

Merged
merged 2 commits into from
Sep 2, 2024
Merged

doc: correct docstrings for integer division and modulus #5230

merged 2 commits into from
Sep 2, 2024

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Sep 2, 2024

Fixes #5204.

@TwoFX TwoFX requested a review from kim-em as a code owner September 2, 2024 06:53
@TwoFX TwoFX added documentation Documentation improvement will-merge-soon …unless someone speaks up labels Sep 2, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 2, 2024 07:10 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase db3631ba1f98891c6db02c46a2b691b6af618648 --onto d31066646dfa7389d818a2e2e1493be6a941924e. (2024-09-02 07:12:35)

TwoFX
TwoFX commented Sep 2, 2024
View reviewed changes
src/Init/Data/Int/DivMod.lean Outdated Show resolved Hide resolved
src/Init/Data/Int/DivMod.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 2, 2024 08:31 Inactive
@TwoFX TwoFX added this pull request to the merge queue Sep 2, 2024
Merged via the queue into master with commit 830b119 Sep 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
documentation Documentation improvement toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstring for Int.mod is misleading
2 participants
@TwoFX @leanprover-community-mathlib4-bot