-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: do not lint unused variables defined in tactics by default #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
force-pushed
the
unused-in-tactics
branch
from
September 13, 2024 11:50
d01f21d
to
448f998
Compare
mhuisi
approved these changes
Sep 13, 2024
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Sep 13, 2024
Collaborator
leanprover-community-mathlib4-bot
commented
Sep 13, 2024
•
edited by leanprover-community-bot
Loading
edited by leanprover-community-bot
Mathlib CI status (docs):
|
Kha
force-pushed
the
unused-in-tactics
branch
from
September 13, 2024 15:58
448f998
to
ea68a45
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 18, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 18, 2024
leanprover-community-bot
added
the
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
label
Sep 18, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 23, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 23, 2024
Kha
force-pushed
the
unused-in-tactics
branch
from
September 23, 2024 11:20
81aa906
to
1e42149
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 23, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 23, 2024
Kha
force-pushed
the
unused-in-tactics
branch
from
September 23, 2024 15:47
1e42149
to
316be7e
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 23, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 23, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 24, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 24, 2024
leanprover-community-bot
added
builds-mathlib
CI has verified that Mathlib builds against this PR
and removed
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
labels
Sep 24, 2024
Kha
force-pushed
the
unused-in-tactics
branch
from
September 24, 2024 14:43
316be7e
to
fb9e582
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 24, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 24, 2024
leanprover-community-bot
added
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
and removed
builds-mathlib
CI has verified that Mathlib builds against this PR
labels
Sep 24, 2024
What is the plan here? It generates a massive number of warnings (~4200) in Mathlib.
Update: All fixed in Mathlib, with adaptation notes for the edge cases. Touches over 900 files. |
Kha
added
the
merge-ci
Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms.
label
Sep 26, 2024
leanprover-community-bot
added
builds-mathlib
CI has verified that Mathlib builds against this PR
and removed
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
labels
Oct 3, 2024
Kha
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 8, 2024
…pensive than traversal over finished proof term
kim-em
force-pushed
the
unused-in-tactics
branch
from
October 16, 2024 22:28
52fb143
to
22f7c34
Compare
kim-em
approved these changes
Oct 16, 2024
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 17, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
merge-ci
Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms.
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should ensure we visit at most as many expr nodes as in the final expr instead of many possibly overlapping mvar assignments. This is likely the only way we can ensure acceptable performance in all cases.