Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: BitVec.Lemmas - drop non-terminal simps #5499

Merged
merged 5 commits into from
Sep 28, 2024

Conversation

tobiasgrosser
Copy link
Contributor

@tobiasgrosser tobiasgrosser commented Sep 27, 2024

BitVec.Lemmas contained a couple of non-terminal simps. We turn non-terminal simp$, simp [, and simp at expressions into simp only to improve code maintainability.

@tobiasgrosser tobiasgrosser marked this pull request as ready for review September 27, 2024 17:59
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 28, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 28, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase ef71f0beabddd0dd272ea55e294d1f2535408195 --onto 0196bca784f82f90b4efd2a85a400daf4ab767f8. (2024-09-28 05:43:31)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase ef71f0beabddd0dd272ea55e294d1f2535408195 --onto 9460f79d28d3a72d7484766b5f2c83362e91dd5b. (2024-09-28 09:27:23)

Copy link
Contributor

@hargoniX hargoniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR supposed to address all of them or only the ones seen here? If it is all of them, did you verify with e.g. grep simp | grep -v "simp only" that you got all of them?

src/Init/Data/BitVec/Lemmas.lean Outdated Show resolved Hide resolved
@tobiasgrosser
Copy link
Contributor Author

tobiasgrosser commented Sep 28, 2024

Is this PR supposed to address all of them or only the ones seen here? If it is all of them, did you verify with, e.g., grep simp | grep -v "simp only" that you got all of them?

I searched now for simp$, simp [, and simp at and manually verified that they are terminal. While this was manual, I tried to be careful to catch all.

@hargoniX hargoniX added this pull request to the merge queue Sep 28, 2024
Merged via the queue into leanprover:master with commit 5605e01 Sep 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants