Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: actual implementation for #5283 #5512

Merged
merged 7 commits into from
Sep 29, 2024
Merged

feat: actual implementation for #5283 #5512

merged 7 commits into from
Sep 29, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Sep 29, 2024 •
edited
Loading

I did a bad git rebase before merging #5283, which reverted it to an earlier version. This PR has the actual implementation of RFC #5397.

@kmill kmill mentioned this pull request Sep 29, 2024
Merged
@kmill kmill enabled auto-merge September 29, 2024 01:03
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 130b465aafc1e68aa08e2989a88e3a64dff5fdad --onto 9460f79d28d3a72d7484766b5f2c83362e91dd5b. (2024-09-29 01:19:36)

@kmill kmill added this pull request to the merge queue Sep 29, 2024
Merged via the queue into leanprover:master with commit 0db6daa Sep 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmill @leanprover-community-bot