Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove docstring from implicitDefEqProofs #5751

Merged
merged 1 commit into from
Oct 17, 2024
Merged

doc: remove docstring from implicitDefEqProofs #5751

merged 1 commit into from
Oct 17, 2024

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Oct 17, 2024 •
edited
Loading

this option was added in fb97275 to
prepare for #4595, due to boostrapping issues, but #4595 has not landed
yet. This is be very confusing when people discover this option and try
to use it (as I did).

So let's clearly mark this as not yet implemented on master, and add the
docstring only with #4595.

@nomeata
docs: remove docstring from implicitDefEqProofs
cdb2259 
this option was added in fb97275 to
prepare for #4595, due to boostrapping issues, but #4595 has not landed
yet. This is be very confusing when people discover this option and try
to use it (as I did).

So let's clearly mark this as not yet implemented on `main`.
@nomeata nomeata changed the title docs: remove docstring from implicitDefEqProofs doc: remove docstring from implicitDefEqProofs Oct 17, 2024
@nomeata nomeata mentioned this pull request Oct 17, 2024
Open
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 17, 2024 09:36 Inactive
@nomeata nomeata added this pull request to the merge queue Oct 17, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 17, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-10-17 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-10-17 09:42:15)

Merged via the queue into master with commit 08d8a08 Oct 17, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomeata @leanprover-community-bot