Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull intMin and intMax up #5762

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luisacicolini
Copy link
Contributor

@luisacicolini luisacicolini commented Oct 18, 2024

I pulled intMin and intMax up in the Lemmas file. To do so, I had to move other sections down. Most significant changes include:

  1. moving toNat_shiftLeft and getLsbD_shiftLeft out of the shiftLeft section, at the very beginning of the file, since these two are crucial to most of the subsequent theorems
  2. changing the proof of add_zero and zero_add
  3. changing some theorems' section (e.g., or_allOnes, allOnes_or, and_allOnes, Std.LawfulCommIdentity, allOnes_and, negOne_eq_allOnes moved from their respective operator section to the allOnes section)

Overall, intMax and intMin are now only preceded by sections twoPow, le and lt, mul, sub/neg, add and the theorems in (1). As far as I could see, these sections are very much interdependent and therefore hard to move further around. Pulling intMax and intMin further up would require breaking up these sections.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 18, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-10-18 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-10-18 08:52:16)

@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Oct 18, 2024
@luisacicolini luisacicolini marked this pull request as draft October 18, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium We may work on this issue if we find the time toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants