refactor: nicer modifiers/ranges API #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 21, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 21, 2024
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
Kha
force-pushed
the
push-qqzkwvsnkrou
branch
from
cf1dd6f
to
d8d9203
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 21, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 21, 2024
|
@kim-em I pushed two cleanup commits based on this to https://github.com/leanprover-community/mathlib4/commits/lean-pr-testing-5788/, I think that's a nice improvement |
Merged. |
tobiasgrosser
pushed a commit
to opencompl/lean4
that referenced
this pull request
Oct 27, 2024
Cleanup of leanprover#5650 * default `Modifiers.stx` to missing * rename and clarify `addDeclarationRangesFromSyntax` as the main convenience function for user metaprograms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of #5650
Modifiers.stxto missingaddDeclarationRangesFromSyntaxas the main convenience function for user metaprograms