feat: support BitVec.ofBool in bv_decide #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
approved these changes
Oct 26, 2024
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2024
Using the same strategy as #5852 this provides `bv_decide` support for `Bool` and `BitVec` ifs this in turn instantly enables support for: - `sdiv` - `smod` - `abs` and thus closes our last discrepancies to QF_BV!
tobiasgrosser
pushed a commit
to opencompl/lean4
that referenced
this pull request
Oct 27, 2024
This is the first step towards fixing the issue of not having mutual recursion between the `Bool` and `BitVec` fragment of `QF_BV` in `bv_decide`. This PR adds support for `BitVec.ofBool` by doing the following: 1. Introduce a new mechanism into the reification engine that allows us to add additional lemmas to the top level on the fly as we are traversing the expression tree. 2. If we encounter an expression `BitVec.ofBool boolExpr` we reify `boolExpr` and then abstract `BitVec.ofBool boolExpr` as some atom `a` 3. We add two lemmas `boolExpr = true -> a = 1#1` and `boolExpr = false -> a = 0#1`. This mirrors the full behavior of `BitVec.ofBool` and thus makes our atom `a` correctly interpreted again. In order to do the reification in step 2 mutual recursion in the reification engine is required. For this reason I started pulling out logic from the, now rather large, mutual block into other files and document the invariants that they assume explicitly.
tobiasgrosser
added a commit
to opencompl/lean4
that referenced
this pull request
Oct 27, 2024
Using the same strategy as leanprover#5852 this provides `bv_decide` support for `Bool` and `BitVec` ifs this in turn instantly enables support for: - `sdiv` - `smod` - `abs` and thus closes our last discrepancies to QF_BV!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards fixing the issue of not having mutual recursion between the
BoolandBitVecfragment ofQF_BVinbv_decide. This PR adds support forBitVec.ofBoolby doing the following:BitVec.ofBool boolExprwe reifyboolExprand then abstractBitVec.ofBool boolExpras some atomaboolExpr = true -> a = 1#1andboolExpr = false -> a = 0#1. This mirrors the full behavior ofBitVec.ofBooland thus makes our atomacorrectly interpreted again.In order to do the reification in step 2 mutual recursion in the reification engine is required. For this reason I started pulling out logic from the, now rather large, mutual block into other files and document the invariants that they assume explicitly.