Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_augmentation for get_tasks #306

Closed
wants to merge 1 commit into from
Closed

Conversation

brando90
Copy link

@brando90 brando90 commented Feb 5, 2022

Description

adding data_augmentation to get_tasksets

Contribution Checklist

If your contribution modifies code in the core library (not docs, tests, or examples), please fill the following checklist.

  • My contribution is listed in CHANGELOG.md with attribution.
  • My contribution modifies code in the main library.
  • My modifications are tested.
  • My modifications are documented.

@seba-1511
Copy link
Member

Hi @brando90 and thanks for this PR,

Unfortunately I think this change goes against the the design principle that get_tasksets should reproduce benchmarks from the literature. My recommendation is to include the augmentations in the benchmarks themselves (like you already did in #303 and #305 -- thanks for that!).

@seba-1511 seba-1511 closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants