accounts-conteroller: use sha256 from @noble/hashes

legobeat · Oct 13, 2023 · a23ee87 · a23ee87
1 parent d506841
commit a23ee87
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/accounts-controller/package.json b/packages/accounts-controller/package.json
@@ -35,6 +35,7 @@
     "@metamask/keyring-api": "^1.0.0",
     "@metamask/snaps-utils": "^3.0.0",
     "@metamask/utils": "^8.1.0",
+    "@noble/hashes": "^1.3.2",
     "deepmerge": "^4.2.2",
     "immer": "^9.0.6",
     "uuid": "^8.3.2"

diff --git a/packages/accounts-controller/src/AccountsController.ts b/packages/accounts-controller/src/AccountsController.ts
@@ -1,4 +1,3 @@
-import { sha256FromString } from '@ethereumjs/util';
 import type { RestrictedControllerMessenger } from '@metamask/base-controller';
 import { BaseControllerV2 } from '@metamask/base-controller';
 import { SnapKeyring } from '@metamask/eth-snap-keyring';
@@ -17,6 +16,7 @@ import type {
 } from '@metamask/snaps-controllers';
 import type { Snap, ValidatedSnapId } from '@metamask/snaps-utils';
 import type { Keyring, Json } from '@metamask/utils';
+import { sha256 } from '@noble/hashes/sha256';
 import type { Patch } from 'immer';
 import { v4 as uuid } from 'uuid';
 
@@ -406,7 +406,7 @@ export class AccountsController extends BaseControllerV2<
         address,
       );
       const v4options = {
-        random: sha256FromString(address).slice(0, 16),
+        random: sha256(address).slice(0, 16),
       };
 
       internalAccounts.push({

diff --git a/yarn.lock b/yarn.lock
@@ -1300,6 +1300,7 @@ __metadata:
     "@metamask/snaps-controllers": ^3.0.0
     "@metamask/snaps-utils": ^3.0.0
     "@metamask/utils": ^8.1.0
+    "@noble/hashes": ^1.3.2
     "@types/jest": ^27.4.1
     "@types/readable-stream": ^2.3.0
     deepmerge: ^4.2.2
@@ -2591,7 +2592,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@noble/hashes@npm:^1.0.0, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:~1.3.0, @noble/hashes@npm:~1.3.1":
+"@noble/hashes@npm:^1.0.0, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:^1.3.2, @noble/hashes@npm:~1.3.0, @noble/hashes@npm:~1.3.1":
   version: 1.3.2
   resolution: "@noble/hashes@npm:1.3.2"
   checksum: fe23536b436539d13f90e4b9be843cc63b1b17666a07634a2b1259dded6f490be3d050249e6af98076ea8f2ea0d56f578773c2197f2aa0eeaa5fba5bc18ba474