wip: permission-controller: @metamask/rpc-errors migration

legobeat · Sep 26, 2023 · a3100b7 · a3100b7
1 parent a957b47
commit a3100b7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/permission-controller/src/PermissionController.test.ts b/packages/permission-controller/src/PermissionController.test.ts
@@ -5271,7 +5271,8 @@ describe('PermissionController', () => {
       };
 
       const expectedError = errors.unauthorized({
-        data: { origin, method: PermissionNames.wallet_getSecretArray },
+        data: { origin, method: PermissionNames.wallet_getSecretArray, cause: null },
+        message: "Unauthorized to perform action. Try requesting the required permission(s) first. For more information, see: https://docs.metamask.io/guide/rpc-api.html#permissions",
       });
 
       const { error }: any = await engine.handle(request);

diff --git a/packages/permission-controller/src/errors.ts b/packages/permission-controller/src/errors.ts
@@ -10,6 +10,7 @@ import type { PermissionType } from './Permission';
 
 type UnauthorizedArg = {
   data?: Record<string, unknown>;
+  message?: string;
 };
 
 /**

diff --git a/packages/permission-controller/src/rpc-methods/requestPermissions.test.ts b/packages/permission-controller/src/rpc-methods/requestPermissions.test.ts
@@ -70,7 +70,11 @@ describe('requestPermissions RPC method', () => {
     });
 
     expect(response.result).toBeUndefined();
-    expect(response.error).toStrictEqual(serializeError(new Error('foo')));
+    delete response.error.stack;
+    delete response.error.data.cause.stack;
+    const expectedError = new Error('foo');
+    delete expectedError.stack;
+    expect(response.error).toStrictEqual(serializeError(expectedError, {shouldIncludeStack: false}));
     expect(mockRequestPermissionsForOrigin).toHaveBeenCalledTimes(1);
     expect(mockRequestPermissionsForOrigin).toHaveBeenCalledWith({}, '1');
   });