-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acc thr red correction as tested #309
Open
flinkeKoralle
wants to merge
26
commits into
legoboyvdlp:dev
Choose a base branch
from
flinkeKoralle:acc-thrRed-correction-as-tested
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Acc thr red correction as tested #309
flinkeKoralle
wants to merge
26
commits into
legoboyvdlp:dev
from
flinkeKoralle:acc-thrRed-correction-as-tested
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Howto test it: |
PERFGA Page is also improved: |
Hey, have you gotten around to do the cleanup you talked about? |
What is the status of this? |
I am not at home this week.(30.9 - 4.10)
I worked on more improvements regarding SRS mode.
I was waiting for a merge from your side, before making a new pull request.
I did some clean up.
…On Sun, Sep 29, 2024, 22:40 Josh Davidson ***@***.***> wrote:
What is the status of this?
—
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDL4HTZVY3YU7BSJSAMFMV3ZZBXUTAVCNFSM6AAAAABPCCF2U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGYZDAMJZGE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
I have improved the code again and could make a new commit to the repo.
But I want to wait until this version (SRS improvement) is merged to the
dev tree.
As soon as this is merged, I can push the newest commit from my local.
Still a work in progress. As soon as I fix something, a new Idea for a fix
arises.
So I am waiting for the merge from frebuary (SRS improvement).
On Mon, Sep 30, 2024 at 8:53 PM Flinke Koralle ***@***.***>
wrote:
… I am not at home this week.(30.9 - 4.10)
I worked on more improvements regarding SRS mode.
I was waiting for a merge from your side, before making a new pull request.
I did some clean up.
On Sun, Sep 29, 2024, 22:40 Josh Davidson ***@***.***>
wrote:
> What is the status of this?
>
> —
> Reply to this email directly, view it on GitHub
> <#309 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BDL4HTZVY3YU7BSJSAMFMV3ZZBXUTAVCNFSM6AAAAABPCCF2U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGYZDAMJZGE>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acceleration altitude and thrust reduction input on PERF-TO corrected
Description of Changes
Once departure airport is chosen, the default company accel/thrRed is set.
The minimum value that can be inserted (manual entry) is the company default.
The company default value can be inserted in the specific livery aircraft.
E.g. DLH is 1000/1000 agl.
To Do:
The acceleration altitude is inserted in the Simple_C5 line of the mcdu.
A better solution would be to implement a split line for split entries on left and right side of mcdu.
Screenshots (optional)
Bugs fixed (if any)
Checklist: