Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add mock mixins #528

Closed
diegotori opened this issue Oct 26, 2023 · 0 comments
Closed

[Feature Request] Add mock mixins #528

diegotori opened this issue Oct 26, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@diegotori
Copy link
Contributor

It's pretty much impossible to mock any of the Chopper related classes due to the recent Dart 3 upgrade, since they're now using either base or final keywords in their class declarations.

Based on the closed PR #479, there was an attempt to add this, but it was tightly coupled with mockito, which may not apply to developers such as myself who don't use it (I happen to use mocktail).

As a result, I propose that we make available (@visibleForTesting of course) mixins that can enable developers to mock out any Chopper related component based on this suggestion from the Dart Team.

I will submit a PR to this effect very shortly.

@diegotori diegotori added the enhancement New feature or request label Oct 26, 2023
diegotori added a commit to diegotori/chopper that referenced this issue Oct 26, 2023
@techouse techouse self-assigned this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants