feat: DEBUG flag and project.json validation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raz-ezra-lmnd
previously approved these changes
May 15, 2024
libs/core/src/true-affected.ts
Outdated
| const tsConfigPath = resolve(cwd, tsConfig); | ||
|
|
||
| if (existsSync(tsConfigPath)) { | ||
| if (verbose) { | ||
| logger.log( |
There was a problem hiding this comment.
@EladBezalel maybe a change in approach, maybe we can start using logger.debug and then we can set the debug level or the DEBUG env var and this way u won't need to do the if (verbose) part and the logger should know how to handle log levels.
wdyt? the benefit here is that this will reduce the amount of branching in code and will make it a bit nicer and u won't have to add additional logic for params
levan-giguashvili-lmnd
approved these changes
Jun 10, 2024
EladBezalel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project.json(missingnameorsourceRootproperties) and fallback-ing to file path