Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #530

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README.md #530

wants to merge 2 commits into from

Conversation

nil-01
Copy link

@nil-01 nil-01 commented Feb 28, 2023

  1. Urgent Notice added in Hindi language. 2.Format the texting and solved few grammatical sentence construction.

1. Urgent Notice added in Hindi language.  2.Format the texting and solved few grammatical sentence construction.
README.md Outdated
---

**It is an unofficial project intended for personal learning and research purposes only. During the time that the ChatGPT desktop application was open-sourced, it received a lot of attention, and I would like to thank everyone for their support. However, as things have developed, there are two issues that seriously affect the project's next development plan:**
**This is an unofficial project intended for personal learning and research purposes only. Since, when ChatGPT desktop application was open-sourced, it received a lot of attention, and I would like to thank everyone for their support. However, as things have developed, there are two issues that seriously affect the project's next development plan:**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English is not sound here. Since, when... don't make good English sense. Rather say Since ChatGPT Desktop Application was made open-source...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review sir

README.md Outdated
@@ -259,7 +262,7 @@ yarn build
## ❤️ Thanks

- The core implementation of the share button code was copied from the [@liady](https://github.com/liady) extension with some modifications.
- Thanks to the [Awesome ChatGPT Prompts](https://github.com/f/awesome-chatgpt-prompts) repository for inspiring the custom command function for this application.
- Thank you to [Awesome ChatGPT Prompts](https://github.com/f/awesome-chatgpt-prompts) repository for inspiring the custom command function for this application.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the to after the Thank you. It should read Thank you [Awesome ChatGPT Prompts] repository...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a nit that I feel weird even chiming in, but I disagree.

This isn't a message directed at a person who identifies as the GitHub repository... it's a general acknowledgement of the repository.

Thank you for review all the update are done
Copy link
Author

@nil-01 nil-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -54,7 +57,7 @@

**Note: If the installation path and application name are the same, it will lead to conflict ([#142](https://github.com/lencx/ChatGPT/issues/142#issuecomment-0.11.0))**

### Mac
### Mac:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contradicts Markdown lint rule MD026 - https://github.com/DavidAnson/markdownlint/blob/main/doc/md026.md

Headings should really not end with punctuation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants