-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing node version and resolving errors of "Position::TrayFixedCenter not found problem" #757
base: main
Are you sure you want to change the base?
Conversation
I have observed that this pull request holds significant importance. Its absence could lead to errors for developers during local development. Would you kindly review this pull request and provide any feedback or merge it at your earliest convenience? Thank you for your valuable time and consideration. |
Hey maintainers, please merge this inmediately |
@lencx Can you have a look and merge this PR? The compilation fails because of this error. |
Great job with this PR, thanks for saving me at least 10 min of my life chasing the bug. I wonder why @lencx does not want to merge it or is avoiding it for some reason ...? Especially if you put in the README.md that there was some trojanized version, I want to compile things on my own and not rely on potentially very dangerous binaries(we are talking Rust here so you can do pretty much anything you want ...) |
This issue is caused by Cargo.lock, not from the code files. I have released the latest version v1.0.0. |
Hmm, if that is the case - I would open a PR that fixes this issue with a simple shell script. I also had to create
What is your opinion, people? There are other cleaner ways though to do this. This issue could have been solved months ago if you replied a little bit earlier. I get it that you don't really care and have time to take care of this for other devs, but this is trivial ... |
No description provided.