Exception when value is null (#9)

* fix: 🐛 exception when value is null * test: ✅ add test for null value
leocavalcante · Apr 19, 2024 · e8f5a41 · e8f5a41
1 parent 95e0e31
commit e8f5a41
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/RedactSensitiveProcessor.php b/src/RedactSensitiveProcessor.php
@@ -95,7 +95,7 @@ private function traverseArr(array $arr, array $keys): array
             } else {
                 if (array_key_exists($key, $keys)) {
                     $arr[$key] = $this->traverse($key, $value, $keys[$key]);
-                } else {
+                } elseif (null !== $value) {
                     $arr[$key] = $this->traverse($key, $value, $keys);
                 }
             }
@@ -115,7 +115,7 @@ private function traverseObj(object $obj, array $keys): object
             } else {
                 if (array_key_exists($key, $keys)) {
                     $obj->{$key} = $this->traverse($key, $value, $keys[$key]);
-                } else {
+                } elseif (null !== $value) {
                     $obj->{$key} = $this->traverse($key, $value, $keys);
                 }
             }

diff --git a/tests/RedactSensitiveTest.php b/tests/RedactSensitiveTest.php
@@ -139,3 +139,11 @@
     $record = $this->getRecord(context: ['test' => fopen(__FILE__, 'rb')]);
     $processor($record);
 })->throws(\UnexpectedValueException::class, 'Don\'t know how to traverse value at key test');
+
+it('ignore when null value', function (): void {
+    $sensitive_keys = ['test' => 3];
+    $processor = new RedactSensitiveProcessor($sensitive_keys);
+
+    $record = $this->getRecord(context: ['test' => 'foobar', 'optionalKey' => null]);
+    expect($processor($record)->context)->toBe(['test' => 'foo***', 'optionalKey' => null]);
+});