Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(closest_test): uses new behavior of the iter_matches function #97

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

florentcigolotti
Copy link
Contributor

@florentcigolotti florentcigolotti commented Sep 12, 2024

See Neovim breaking change PR: neovim/neovim#30193

Now iter_matches by default returns a list of node.
Iterates over all nodes with backward compatibility using the all = true option.

Fixes #96

@florentcigolotti
Copy link
Contributor Author

I am testing the fix with nightly and older version of Neovim today.

@florentcigolotti
Copy link
Contributor Author

Working fine with:

  • Before breaking change: v0.10.2-dev-40+g23a9c67f1b
  • With breaking change: v0.11.0-dev-758+g48c14d3544

See neovim breaking change PR: neovim/neovim#30193
Now iter_matches by default returns a list of node.
Iterates over all nodes with backward compatibility
@leoluz leoluz merged commit 6aa8816 into leoluz:main Oct 3, 2024
2 checks passed
@leoluz
Copy link
Owner

leoluz commented Oct 3, 2024

I also validated with v0.10.1 and it is working fine.
@florentcigolotti Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug closest test failure in Neovim nightly due to breaking change in iter_matches
2 participants