Skip to content

Commit

Permalink
Fixes interference with assign form
Browse files Browse the repository at this point in the history
Issue: documentacao-e-tarefas/scielo#707

Signed-off-by: Jhon <jhon@lepidus.com.br>
  • Loading branch information
JhonathanLepidus committed Oct 10, 2024
1 parent c5c5311 commit 870dc7a
Show file tree
Hide file tree
Showing 7 changed files with 29 additions and 5 deletions.
2 changes: 2 additions & 0 deletions classes/dispatchers/DatasetTabDispatcher.php
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ private function setupResearchDataDeposit(Submission $submission): void

$templateMgr->setState([
'dataversePluginApiUrl' => $dataversePluginApiUrl,
'loadingCitationMsg' => __('plugins.generic.dataverse.metadataForm.loadingDatasetCitation'),
'hasDepositedDataset' => false
]);
}
Expand Down Expand Up @@ -212,6 +213,7 @@ private function setupResearchDataUpdate(Submission $submission, DataverseStudy
'confirmPublishDatasetMessage' => __('plugins.generic.dataverse.modal.confirmDatasetPublish', [
'serverUrl' => $configuration->getDataverseServerUrl(),
]),
'loadingCitationMsg' => __('plugins.generic.dataverse.metadataForm.loadingDatasetCitation'),
'datasetCitationUrl' => $dispatcher->url($request, Application::ROUTE_API, $context->getPath(), 'datasets/' . $study->getId() . '/citation'),
'canSendEmail' => in_array(Role::ROLE_ID_MANAGER, $userRoles),
'hasDepositedDataset' => true
Expand Down
6 changes: 5 additions & 1 deletion js/DataverseWorkflowPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ var DataverseWorkflowPage = $.extend(true, {}, pkp.controllers.WorkflowPage, {
},

datasetIsPublished: function () {
if (this.datasetIsLoading) {
return true;
}

return this.dataset.versionState === 'RELEASED';
},

Expand Down Expand Up @@ -225,7 +229,7 @@ var DataverseWorkflowPage = $.extend(true, {}, pkp.controllers.WorkflowPage, {
return;
}
var self = this;
this.datasetCitation = this.__('common.loading') + '...';
this.datasetCitation = this.loadingCitationMsg;
$.ajax({
url: self.datasetCitationUrl,
data: {
Expand Down
6 changes: 6 additions & 0 deletions locale/en/locale.po
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,12 @@ msgstr "Publish research data"
msgid "plugins.generic.dataverse.dataset.titlePrefix"
msgstr "Replication data for: "

msgid "plugins.generic.dataverse.metadataForm.loadingDataset"
msgstr "Loading research data information..."

msgid "plugins.generic.dataverse.metadataForm.loadingDatasetCitation"
msgstr "Loading citation..."

msgid "plugins.generic.dataverse.metadataForm.title"
msgstr "Title"

Expand Down
6 changes: 6 additions & 0 deletions locale/es/locale.po
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,12 @@ msgstr "Publicar datos de investigación"
msgid "plugins.generic.dataverse.dataset.titlePrefix"
msgstr "Datos de réplica: "

msgid "plugins.generic.dataverse.metadataForm.loadingDataset"
msgstr "Cargando información de los datos de investigación..."

msgid "plugins.generic.dataverse.metadataForm.loadingDatasetCitation"
msgstr "Cargando citación..."

msgid "plugins.generic.dataverse.metadataForm.title"
msgstr "Título"

Expand Down
6 changes: 6 additions & 0 deletions locale/pt_BR/locale.po
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,12 @@ msgstr "Publicar dados de pesquisa"
msgid "plugins.generic.dataverse.dataset.titlePrefix"
msgstr "Dados de replicação para: "

msgid "plugins.generic.dataverse.metadataForm.loadingDataset"
msgstr "Carregando informações dos dados de pesquisa..."

msgid "plugins.generic.dataverse.metadataForm.loadingDatasetCitation"
msgstr "Carregando citação..."

msgid "plugins.generic.dataverse.metadataForm.title"
msgstr "Título"

Expand Down
4 changes: 2 additions & 2 deletions templates/datasetTab/datasetData.tpl
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<span v-if="datasetIsLoading">
<spinner></spinner>
{{ __('common.loading')}} ...
{translate key="plugins.generic.dataverse.metadataForm.loadingDataset"}
</span>
<section v-if="!datasetIsLoading" id="datasetData" class="item datasetData -pkpClearfix">
<section id="datasetData" class="item datasetData -pkpClearfix">
<pkp-header>
<h1>
{translate key="plugins.generic.dataverse.researchData"}
Expand Down
4 changes: 2 additions & 2 deletions version.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
<version>
<application>dataverse</application>
<type>plugins.generic</type>
<release>3.1.0.0</release>
<date>2024-09-30</date>
<release>3.1.1.0</release>
<date>2024-10-10</date>
<lazy-load>1</lazy-load>
<class>DataversePlugin</class>
</version>

0 comments on commit 870dc7a

Please sign in to comment.