Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor Accounts table #108

Merged
merged 2 commits into from
Jan 28, 2024
Merged

feat: Refactor Accounts table #108

merged 2 commits into from
Jan 28, 2024

Conversation

letehaha
Copy link
Owner

@letehaha letehaha commented Jan 28, 2024 •
edited
Loading

This change is required for a few reasons:

  1. Get rid of useless data normalization.
  2. Make the Accounts table more descriptive by replacing the numeric id with a descriptive enum.
  3. To easily extend this in the future and make Investments functionality less verbose.

@letehaha
feat: Refactor Accounts table
a80f359 
- delete `AccountTypes` table
- change `accountTypeId` to `accountCategory`
- update Accounts model, controller, service, and tests, to reflect changes
@letehaha letehaha added the enhancement New feature or request label Jan 28, 2024
@letehaha letehaha self-assigned this Jan 28, 2024
@letehaha letehaha merged commit 5c174c5 into main Jan 28, 2024
4 checks passed
@letehaha letehaha deleted the refactor/account-types-to-categories branch January 28, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@letehaha letehaha

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@letehaha