[ESP_IDF 5.1] Add support for ESP_IDF 5.1 (ESP32 Arduino SDK 3.x) #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TD-er
changed the title
tonhuisman
reviewed
Dec 19, 2023
src/src/WebServer/AccessControl.cpp
Outdated
| return ip.v4() <= high.v4(); | ||
| // FIXME TD-er: Must check whether both are of same type and check full range IPv6 | ||
| for (int i = 0; i < 4; ++i) { | ||
| if (ip[i] != ip[i]) { |
There was a problem hiding this comment.
Typo? I'd expect if (ip[i] != high[i]) {
tonhuisman
reviewed
Dec 21, 2023
| @@ -43,6 +43,9 @@ struct EthernetEventData_t { | |||
|
|
|||
|
|
|||
| void markGotIP(); | |||
| #if FEATURE_USE_IPV6 | |||
| void martGotIP6(const IPAddress& ip6); | |||
There was a problem hiding this comment.
I'd expected that toe be named markGotIPv6, perhaps? (so, with a k instead of a t, and maybe a v inserted ?)
There was a problem hiding this comment.
Nah, Mart got the 6th IP, that's all... ;)
In 20230505 build some extra data was added which was not present on older builds. However this data is being used as an extra check for validity of data. So ESPEasy should not check for these on packets received from nodes running an older build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday Arduino for ESP32 moved on to ESP IDF 5.1
This means a lot of changes are needed to support this new IDF.
Also we can't use SPIFFS anymore, so this migration may be partially at first.
ToDo:
webserver.client().remoteIP()does not work anymore)Now with WiFi6 support (802.11ax) for ESP32-C6:
It would be greatly appreciated if someone else could also test some of the builds based on this PR.
GH Actions builds are uploaded to the 'latest' web flasher location
N.B. Only the ESP32 LittleFS bin files are based on IDF5.1