Fix more lints

ca/ca.go

@@ -116,7 +116,7 @@ func makeCertificateProfilesMap(origProfile *issuance.Profile, certProfiles []*i
 		if profilesByName[profile.Name()] == nil {
 			profilesByName[profile.Name()] = profile
 		} else {
-			return nil, errors.New(fmt.Sprintf("duplicate certificate profile name %+v", profile))
+			return nil, fmt.Errorf("duplicate certificate profile name %+v", profile)
 		}
 	}
 

ca/ca_test.go

@@ -522,10 +522,11 @@ func TestProfiles(t *testing.T) {
 	// existence of both profile and certProfiles without a duplicate name (the
 	// happy path).
 	testCases := []struct {
-		name            string
-		profile         *issuance.Profile
-		certProfiles    []*issuance.Profile
-		expectErrSubstr string
+		name              string
+		profile           *issuance.Profile
+		certProfiles      []*issuance.Profile
+		expectErrSubstr   string
+		expectProfileName string
 	}{
 		{
 			name:            "both empty",
@@ -540,9 +541,10 @@ func TestProfiles(t *testing.T) {
 			expectErrSubstr: "at least one certificate profile",
 		},
 		{
-			name:         "no certProfiles",
-			profile:      ctx.profile,
-			certProfiles: nil,
+			name:              "no certProfiles",
+			profile:           ctx.profile,
+			certProfiles:      nil,
+			expectProfileName: "defaultCertificateProfileName",
 		},
 		{
 			name:            "both exist, but have a duplicate profile name",
@@ -554,7 +556,7 @@ func TestProfiles(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			_, err := NewCertificateAuthorityImpl(
+			tCA, err := NewCertificateAuthorityImpl(
 				sa,
 				ctx.pa,
 				ctx.boulderIssuers,
@@ -578,6 +580,8 @@ func TestProfiles(t *testing.T) {
 				test.AssertError(t, err, "No profile found during CA construction.")
 			} else {
 				test.AssertNotError(t, err, "Profiles should exist, but were not found")
+				err = tCA.certificateProfileExists(tc.expectProfileName)
+				test.AssertNotError(t, err, "Profile name not found in map")
 			}
 		})
 	}