Address latest round of comments

letsencrypt · Mar 19, 2024 · 7ab01c0 · 7ab01c0
1 parent d03075f
commit 7ab01c0
Showing 1 changed file with 2 additions and 23 deletions.
diff --git a/sa/saro.go b/sa/saro.go
@@ -717,30 +717,9 @@ func (ssa *SQLStorageAuthorityRO) GetOrder(ctx context.Context, req *sapb.OrderR
 
 		var order *corepb.Order
 		if features.Get().MultipleCertificateProfiles {
-			order, err = modelToOrderv2(
-				&orderModelv2{
-					ID:                     omObj.(*orderModelv2).ID,
-					RegistrationID:         omObj.(*orderModelv2).RegistrationID,
-					Expires:                omObj.(*orderModelv2).Expires,
-					Created:                omObj.(*orderModelv2).Created,
-					Error:                  omObj.(*orderModelv2).Error,
-					CertificateSerial:      omObj.(*orderModelv2).CertificateSerial,
-					BeganProcessing:        omObj.(*orderModelv2).BeganProcessing,
-					CertificateProfileName: omObj.(*orderModelv2).CertificateProfileName,
-				},
-			)
+			order, err = modelToOrderv2(omObj.(*orderModelv2))
 		} else {
-			order, err = modelToOrderv1(
-				&orderModelv1{
-					ID:                omObj.(*orderModelv1).ID,
-					RegistrationID:    omObj.(*orderModelv1).RegistrationID,
-					Expires:           omObj.(*orderModelv1).Expires,
-					Created:           omObj.(*orderModelv1).Created,
-					Error:             omObj.(*orderModelv1).Error,
-					CertificateSerial: omObj.(*orderModelv1).CertificateSerial,
-					BeganProcessing:   omObj.(*orderModelv1).BeganProcessing,
-				},
-			)
+			order, err = modelToOrderv1(omObj.(*orderModelv1))
 		}
 		if err != nil {
 			return nil, err