Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFE/ARI: Add method for tracking certificate replacement #7298

Merged
merged 10 commits into from
Feb 26, 2024
Merged

WFE/ARI: Add method for tracking certificate replacement #7298

merged 10 commits into from
Feb 26, 2024

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Feb 1, 2024 •
edited
Loading

Implement draft-ietf-acme-ari-02 changes in WFE newOrder:

  • Add a replaces field to the newOrder request object
  • Ensure that replaces values provided by subscribers are vetted according to the requirements set out in the draft specification
  • When a NewOrder request falls inside the suggested RenewalWindow, exempt from rate limits in the WFE and indicate exemption in the RA NewOrder request

Part of #7038

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

@beautifulentropy, this PR appears to contain configuration changes. Please ensure that a corresponding deployment ticket has been filed with the new configuration values.

@beautifulentropy beautifulentropy marked this pull request as ready for review February 1, 2024 20:41
@beautifulentropy beautifulentropy requested a review from a team as a code owner February 1, 2024 20:41
pgporada
pgporada requested changes Feb 2, 2024
View reviewed changes
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
core/objects.go Show resolved Hide resolved
@beautifulentropy beautifulentropy mentioned this pull request Feb 7, 2024
Merged
aarongable
aarongable reviewed Feb 8, 2024
View reviewed changes
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy mentioned this pull request Feb 13, 2024
Open
pgporada
pgporada reviewed Feb 16, 2024
View reviewed changes
core/objects.go Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy mentioned this pull request Feb 16, 2024
Merged
pgporada
pgporada reviewed Feb 16, 2024
View reviewed changes
core/objects_test.go Outdated Show resolved Hide resolved
pgporada
pgporada previously approved these changes Feb 16, 2024
View reviewed changes
@beautifulentropy beautifulentropy requested a review from a team February 16, 2024 20:01
jsha
jsha requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Could you extract the new section of NewOrder into its own function, returning replaces, limitsExempt, and error?

wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
wfe2/wfe.go Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy removed the request for review from aarongable February 23, 2024 23:56
pgporada
pgporada previously approved these changes Feb 26, 2024
View reviewed changes
jsha
jsha reviewed Feb 26, 2024
View reviewed changes
wfe2/wfe.go Show resolved Hide resolved
@jsha
Copy link
Contributor

jsha commented Feb 26, 2024

Generally looks great! After that one comment tweak, ready to approve.

jsha
jsha approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@beautifulentropy beautifulentropy merged commit a97e074 into main Feb 26, 2024
19 checks passed
@beautifulentropy beautifulentropy deleted the wfe-replacement-orders branch February 26, 2024 21:47
@ldez ldez mentioned this pull request Mar 10, 2024
Closed
3 tasks
@beautifulentropy beautifulentropy mentioned this pull request May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable left review comments

@pgporada pgporada pgporada approved these changes

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beautifulentropy @jsha @pgporada @aarongable