SA: store and return certificate profile name #7352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
requested changes
Mar 6, 2024
There was a problem hiding this comment.
This change needs to be rebased to only contain the SA changes. Also, the SA (well, //core, really) changes seem so small that I think they can be done in the same PR as adding actual SA support.
This change is also going to need to add the profile name to sapb.NewOrderRequest.
pgporada
changed the title
|
@pgporada, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
pgporada
force-pushed
the
7324-add-certprofilename-to-order-protobuf-message
branch
from
3e878bf to
fcdd44b
Compare
aarongable
reviewed
Mar 8, 2024
aarongable
reviewed
Mar 12, 2024
|
SRE ticket IN-10145 has been filed to perform the database migration and enable the new feature flag. |
aarongable
reviewed
Mar 18, 2024
aarongable
reviewed
Mar 19, 2024
aarongable
approved these changes
Mar 19, 2024
beautifulentropy
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
certificateProfileNameto theordersdatabase table. The maximum length of a profile name matches the//issuancepackage.Adds a
MultipleCertificateProfilesfeature flag that, when enabled, will store the certificate profile name from aNewOrderRequest. The certificate profile name is allowed to be empty and the database will treat that row as NULL. When the SA retrieves this potentially NULL row, it will be cast as the golang string zero value"".SRE ticket IN-10145 has been filed to perform the database migration and enable the new feature flag. The migration must be performed before enabling the feature flag.
Part of #7324
Part of #7309