Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise available profiles in directory resource #7603

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Jul 17, 2024

Change the way profiles are configured at the WFE to allow them to be accompanied by descriptive strings. Augment the construction of the directory resource's "meta" sub-object to include these profile names and descriptions.

This config swap is safe, since no Boulder WFE instance is configured with CertificateProfileNames yet.

Fixes #7602

No config ticket is necessary at this time, since config changes will be made as part of the larger #7309

@aarongable aarongable requested a review from a team as a code owner July 17, 2024 20:52
Copy link
Contributor

@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@aarongable
Copy link
Contributor Author

The resulting directory resource looks like this:

{
  "keyChange": "http://10.77.77.77:4001/acme/key-change",
  "meta": {
    "caaIdentities": [
      "happy-hacker-ca.invalid"
    ],
    "profiles": {
      "defaultBoulderCertificateProfile": "The normal profile you know and love"
    },
    "termsOfService": "https://boulder.service.consul:4431/terms/v7",
    "website": "https://github.com/letsencrypt/boulder"
  },
  "newAccount": "http://10.77.77.77:4001/acme/new-acct",
  "newNonce": "http://10.77.77.77:4001/acme/new-nonce",
  "newOrder": "http://10.77.77.77:4001/acme/new-order",
  "renewalInfo": "http://10.77.77.77:4001/draft-ietf-acme-ari-03/renewalInfo",
  "revokeCert": "http://10.77.77.77:4001/acme/revoke-cert",
  "xEq2aJUaF48": "https://community.letsencrypt.org/t/adding-random-entries-to-the-directory/33417"
}

@letsencrypt letsencrypt deleted a comment from github-actions bot Jul 17, 2024
@aarongable aarongable requested a review from jsha July 19, 2024 23:40
@aarongable aarongable merged commit 48439e4 into main Jul 22, 2024
15 checks passed
@aarongable aarongable deleted the wfe-profile-advertisement branch July 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WFE: Advertise available profiles in directory meta
2 participants