Configure lints separately for each profile #7636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
previously approved these changes
Jul 29, 2024
aarongable
force-pushed
the
per-profile-lints
branch
from
9126a31 to
8c78ad1
Compare
|
@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
|
Now that #7622 has landed, I've rebased this on top of |
jsha
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the two lint-configuration keys, LintConfig and IgnoreLints, from the top-level CA.Issuance config stanza into each individual CA.Issuance.CertProfiles stanza. This allows us to have differently-configured lints for different profiles, to ensure that our linting regime is as strict as possible.
Without this change, it would be necessary for us to ignore both the "common name included" and the "no subject key id" lints at the top-level, when in fact each of those warnings only triggers on one of our two profiles.
Fixes #7635
No config change necessary at this time; that will happen as part of #7309
DO NOT MERGE until after #7622