Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFE: Improve UX when the JWT is malformed or expired #7637

Merged
merged 2 commits into from
Jul 31, 2024
Merged

SFE: Improve UX when the JWT is malformed or expired #7637

merged 2 commits into from
Jul 31, 2024

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Jul 26, 2024 •
edited
Loading

Currently, the SFE displays "An error occurred while unpausing your account" in scenarios where it's not correct or helpful.

  • Return a helpful message when a Subscriber attempts to access the unpause form but fails to copy the entire link
  • Return a helpful message when a Subscriber attempts to unpause using an expired JWT
  • Some small cleanups that make the code a little more mistake-proof.

Part of #7406

@beautifulentropy beautifulentropy requested a review from a team as a code owner July 26, 2024 21:48
jsha
jsha requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great! Nice UX improvements.

sfe/sfe.go Outdated Show resolved Hide resolved
sfe/sfe.go Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy requested a review from jsha July 29, 2024 21:38
@beautifulentropy beautifulentropy mentioned this pull request Jul 30, 2024
Merged
@beautifulentropy beautifulentropy changed the title SFE: Handle various unpause failure scenarios SFE: Improve UX when the JWT is malformed or expired Jul 31, 2024
@beautifulentropy beautifulentropy merged commit 36a617a into main Jul 31, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the sfe-error-cases branch July 31, 2024 14:58
@aarongable aarongable mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beautifulentropy @jsha @aarongable