Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup 'CheckRenewalExemptionAtWFE' feature flag #7680

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cleanup 'CheckRenewalExemptionAtWFE' feature flag #7680

wants to merge 2 commits into from

Conversation

ldlb9527
Copy link

Cleanup CheckRenewalExemptionAtWFE feature flag,it now determines exemption based on the isRenewal parameter.

fixes: #7511

@ldlb9527 ldlb9527 requested a review from a team as a code owner August 27, 2024 04:27
aarongable
aarongable requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before landing this change, we need to land a separate change which enables this flag in the //test/config/[ra|wfe2].json files.

@ldlb9527
Copy link
Author

ldlb9527 commented Sep 9, 2024

Before landing this change, we need to land a separate change which enables this flag in the //test/config/[ra|wfe2].json files.

For the separate change, what can I do to help move this forward?

@beautifulentropy
Copy link
Member

beautifulentropy commented Sep 11, 2024 •
edited
Loading

Before landing this change, we need to land a separate change which enables this flag in the //test/config/[ra|wfe2].json files.

For the separate change, what can I do to help move this forward?

I've added a PR to do this (#7706).

@ldlb9527
Copy link
Author

I've added a PR to do this (#7706).

Once this PR is merged and passes the tests, I need to rebase and remove all the CheckRenewalExemptionAtWFE flags, including the ones added by this PR, right?

@beautifulentropy
Copy link
Member

I've added a PR to do this (#7706).

Once this PR is merged and passes the tests, I need to rebase and remove all the CheckRenewalExemptionAtWFE flags, including the ones added by this PR, right?

Yes, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ratelimits: Cleanup CheckRenewalExemptionAtWFE feature flag
3 participants
@ldlb9527 @beautifulentropy @aarongable