ci: remove AppVeyor file #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpherrinm
approved these changes
Mar 13, 2024
aarongable
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
AppVeyor has been removed. Branch protection is enabled, but doesn't currently condition on these specific checks, because having a list of fifteen required checks enumerated in the settings is annoying. The boulder repo solves this by having one meta-check that depends on all the others, but that also has its disadvantages. I'll figure out something reasonable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448
You should also disable AppVeyor inside the repo settings.
Sidenote: I recommend enabling branch protection to protect the merge of PRs that break the CI.