Require HS256, HS384, or HS512 for EAB #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the jose.v4 upgrade, I accidentally required the same signature sets for EAB as for the account keys, which is incorrect. This allows the correct MAC-based algorithms. It drops the custom algorithm checks, which are now unreachable as go-jose will enforce the algorithms.
Closed
mcpherrinm
force-pushed
the
mattm-fix-455-eab-mac
branch
2 times, most recently
from
d539c67 to
680d520
Compare
mcpherrinm
force-pushed
the
mattm-fix-455-eab-mac
branch
from
680d520 to
c8c1f39
Compare
With PEBBLE_VA_ALWAYS_VALID, we don't need to complete a challenge, but have lego listen on a high port to avoid permission problems.
mcpherrinm
force-pushed
the
mattm-fix-455-eab-mac
branch
from
e8b1500 to
4f618d0
Compare
|
Running this same integration tests against the current main branch has lego return the expected error from #455: |
The acme rfc states that clients should interpret supplied eab keys as base64url. To encourage that behaviour, this commit adds a key to the example configuration that is only decodable by base64url.
|
I've cherry-picked the command and switched to the key from #428 to make the EAB integration test hit the "base64url" edge-case |
aarongable
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the go-jose/v4 upgrade, I accidentally required the same signature sets for EAB as for the account keys, which is incorrect. This allows the correct MAC-based algorithms. It drops the custom algorithm checks, which are now unreachable as go-jose will enforce the algorithms.
Fixes #455