Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release #11

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Prepare release #11

merged 2 commits into from
Aug 12, 2024

Conversation

chrzyki
Copy link
Contributor

@chrzyki chrzyki commented Aug 2, 2024

Should #9 be attempted as well before the release?

@FredericBlum
Copy link
Contributor

I think we should try, yes. If I see this correctly, there is always tone defined after the vowels; also after /v/. So the easiest option would probably be to add things like [v1] and [v33] as vowels with the corresponding tone afterwards. And then watch carefully that this changes only the correct cases.

Copy link
Contributor

@FredericBlum FredericBlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about /v/

@FredericBlum
Copy link
Contributor

@chrzyki I have added a fix that changes all occurrences of v before tones to the indicated vowel symbol (#9 )

@chrzyki
Copy link
Contributor Author

chrzyki commented Aug 12, 2024

Thanks, so this closes #9 .

@chrzyki chrzyki merged commit 49b987a into master Aug 12, 2024
1 check passed
@chrzyki chrzyki deleted the release-prep branch August 12, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants