Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive PDF viewer #26

Merged
merged 21 commits into from
Jan 30, 2024
Merged

Add interactive PDF viewer #26

merged 21 commits into from
Jan 30, 2024

Conversation

lfoppiano
Copy link
Owner

@lfoppiano lfoppiano commented Dec 16, 2023 •
edited
Loading

  1. Integrate the streamlit-pdf-viewer (under development)
  2. Change grobid interaction to return coordinates for the text body (now only available for sentences, so we need to find a way to merge them.
  3. Show sentences contributing to the answers on top of the PDF document
  4. Use colours based on ranking from warmer to colder
  5. Chunks are approximated based on the paragraphs, to preserve the original coordinates
image image

@lfoppiano lfoppiano marked this pull request as draft December 16, 2023 02:30
@lfoppiano lfoppiano linked an issue Jan 15, 2024 that may be closed by this pull request
interact with the pdf document loaded #14
Closed
@lfoppiano lfoppiano self-assigned this Jan 20, 2024
@lfoppiano lfoppiano added the enhancement New feature or request label Jan 20, 2024
@lfoppiano lfoppiano marked this pull request as ready for review January 20, 2024 06:33
@lfoppiano
Copy link
Owner Author

@t29mato I've removed the checkbox to show / hide the annotations. Is that OK?

@t29mato
Copy link
Collaborator

t29mato commented Jan 21, 2024

@t29mato I've removed the checkbox to show / hide the annotations. Is that OK?

Sure!

@lfoppiano
Copy link
Owner Author

lfoppiano commented Jan 30, 2024 •
edited
Loading

Quick demo of the current version: https://youtu.be/SEMy0T0XuAo
Demo: https://lfoppiano-document-qa-develop.hf.space/

I think, after some tests, we can merge.

@lfoppiano lfoppiano merged commit b042214 into main Jan 30, 2024
2 checks passed
@lfoppiano lfoppiano deleted the add-pdf-viewer branch January 30, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t29mato t29mato Awaiting requested review from t29mato

Assignees

@lfoppiano lfoppiano

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interact with the pdf document loaded
2 participants
@lfoppiano @t29mato