Pymake #1234
Open
Pymake #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've close this for now, as I had a failed build in our CI system. There might be some simple compiler flags to change. |
|
This two stage approach requires -fPIC to be set when building libminimap.a on Linux. |
|
I'm still in two minds as to whether this is the best way to perform the build. It has the advantage of not needing to duplicate and maintain the tortuous logic of the makefile of which things to build, but does require make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redoes #868 only it adds the crucial
include *.cinto the MANIFEST file used to create the source distribution tarball.It can be tested with:
then navigating to the output directory and installing: