-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include type declarations in package #106
Conversation
@apancutt thank you so much for this! Highly appreciated. Do we also need to add JSDoc to the functions in utils.js? |
No need for JSDoc in Since the return type is declared loosely as If users have already installed While this is not a breaking change, it possibly should be a minor version bump to indicate to consumers that something significant has changed - highlighting that they should remove |
Any further news on this? it would be a huge improvement for this package to not depend on some ambigous typings. |
I came across with problem when client part of my project depends on webpack 5 typings, but server part use previous versions typings included in @types/webpack-node-externals. So why that MR does not merge? I think not only i have issues with outdated typings. |
@VitalyLipko I'm mainly concerned by it breaking for existing users who are using @types/webpack-node-externals. Thinking about making this a breaking change, just for this reason. |
I think release version with breaking changes is normal practice. Sooner or later it must be happens, so users have to keep themselves in the loop with change in dependencies and update to actual versions. |
Do we have updates? I thought the decision was made #106 (comment) |
Just wanted to drop a comment to bump this into view again. Any updates? |
Fixes #105
Adds JSDoc to allow declaration files to be generated by
tsc
. TypeScript users would no longer be required to install@types/webpack-node-externals
.