Update version number to be PEP 440 compliant #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 440 specifies what is and is not a valid version identifier for Python packages. Using just the first seven characters of the commit hash, as we were doing, was not compliant. This started causing an increasing number of problems as packages dropped support for non-PEP 440 compliant versions. Having to pin to an older
setuptoolswas one of work-arounds we had to do.Thankfully, prepending a
0+gto the commit hash is enough to make the version number compliant again. :)[Note, the
gis not strictly necessary but apparently is best practice for denoting which version control system (e.g. "g" for Git) was used to make the hash.]