Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python and cibuildwheel versions #649

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

ATM-Jahid
Copy link
Contributor

This should resolve #645.

@ATM-Jahid ATM-Jahid mentioned this pull request Jul 1, 2024
docker/Dockerfile Outdated Show resolved Hide resolved
@jameskermode
Copy link
Member

jameskermode commented Jul 2, 2024

Thanks! I don't think the failures are related to your changes, but I'll try to fix them on separate PR and then ask you to rebase on the updated main first so we don't get a mangled release.

@ATM-Jahid
Copy link
Contributor Author

Thank you, @jameskermode.
I am assuming the build errors have something to do with f90wrap.

@ATM-Jahid
Copy link
Contributor Author

I changed the upper bound of f90wrap to use a version that precedes the current public commit 694dc9c. QUIP gets built, but it fails on the tests. So, I'm adding an upper bound for numpy as well.

@jameskermode
Copy link
Member

Thanks, yes, this is likely what's needed. Numpy 2 will break a lot of builds.

@jameskermode
Copy link
Member

The remaining test failures are due to a recent change in ASE. I'll push a fix for them shortly then we can get this merged.

@jameskermode jameskermode merged commit 8e99b0a into libAtoms:public Jul 2, 2024
8 checks passed
@ATM-Jahid ATM-Jahid deleted the bump-py branch July 2, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 support
2 participants