Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Fix return type errors from macros #658

Merged
merged 1 commit into from
Jul 18, 2024
Merged

MAINT: Fix return type errors from macros #658

merged 1 commit into from
Jul 18, 2024

Conversation

HaoZeke
Copy link
Contributor

@HaoZeke HaoZeke commented Jul 18, 2024 •
edited
Loading

Will raise an error with -Wreturn-types otherwise. Basically the preprocessor macros are used in functions without void, so return; is incorrect.

Closes #656.

@jameskermode
Copy link
Member

Thanks!

@jameskermode jameskermode merged commit 4ee283f into libAtoms:public Jul 18, 2024
8 checks passed
@HaoZeke HaoZeke deleted the fixRetType branch July 18, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameskermode jameskermode jameskermode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make libquip.a fails on GCC-14 (darwin_arm64_gfortran)
2 participants
@HaoZeke @jameskermode