Merge pull request #484 from evoskuil/master

Check for txs.empty() upon association.
libbitcoin · Jun 2, 2024 · 70962ad · 70962ad
2 parents eebe66b + e32eb7c
commit 70962ad
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/include/bitcoin/database/error.hpp b/include/bitcoin/database/error.hpp
@@ -118,6 +118,7 @@ enum error_t : uint8_t
     tx_tx_commit,
 
     /// txs archive
+    txs_empty,
     txs_header,
     txs_txs_put,
     txs_confirm

diff --git a/include/bitcoin/database/impl/query/archive.ipp b/include/bitcoin/database/impl/query/archive.ipp
@@ -965,6 +965,9 @@ code CLASS::set_code(txs_link& out_fk, const transactions& txs,
     if (key.is_terminal())
         return error::txs_header;
 
+    if (txs.empty())
+        return error::txs_empty;
+
     ////// GUARD (block (txs) redundancy)
     ////// This is only fully effective if there is a single database thread.
     ////// Guard must be lifted for an existing top malleable association so

diff --git a/src/error.cpp b/src/error.cpp
@@ -110,6 +110,7 @@ DEFINE_ERROR_T_MESSAGE_MAP(error)
     { tx_tx_commit, "tx_tx_commit" },
 
     // tx archive
+    { txs_empty, "txs_empty" },
     { txs_header, "txs_header" },
     { txs_txs_put, "txs_txs_put" },
     { txs_confirm, "txs_confirm" }

diff --git a/test/error.cpp b/test/error.cpp
@@ -603,6 +603,15 @@ BOOST_AUTO_TEST_CASE(error_t__code__txs_header__true_exected_message)
     BOOST_REQUIRE_EQUAL(ec.message(), "txs_header");
 }
 
+BOOST_AUTO_TEST_CASE(error_t__code__txs_empty__true_exected_message)
+{
+    constexpr auto value = error::txs_empty;
+    const auto ec = code(value);
+    BOOST_REQUIRE(ec);
+    BOOST_REQUIRE(ec == value);
+    BOOST_REQUIRE_EQUAL(ec.message(), "txs_empty");
+}
+
 BOOST_AUTO_TEST_CASE(error_t__code__txs_txs_put__true_exected_message)
 {
     constexpr auto value = error::txs_txs_put;