Merge pull request #1513 from evoskuil/master

Use BC_API, make retainer and default_arena final.
libbitcoin · Aug 1, 2024 · e6cbbfc · e6cbbfc
2 parents 8d06d32 + d84fb96
commit e6cbbfc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/include/bitcoin/system/allocator.hpp b/include/bitcoin/system/allocator.hpp
@@ -257,6 +257,7 @@ class allocator
     }
 
 private:
+    // This is thread safe.
     arena* arena_;
 };
 

diff --git a/include/bitcoin/system/arena.hpp b/include/bitcoin/system/arena.hpp
@@ -74,7 +74,7 @@ bool operator==(const arena& left, const arena& right) NOEXCEPT;
 /// quuxplusone.github.io/blog/2023/06/02/not-so-quick-pmr
 /// quuxplusone.github.io/blog/2023/06/03/p1144-pmr-koans
 /// ***************************************************************************
-class default_arena
+class BC_API default_arena final
   : public arena
 {
 public:

diff --git a/include/bitcoin/system/retainer.hpp b/include/bitcoin/system/retainer.hpp
@@ -26,7 +26,7 @@
 namespace libbitcoin {
 
 /// Shared lock object to inform allocator that memory may be freed.
-class retainer
+class BC_API retainer final
 {
 public:
     using ptr = std::shared_ptr<retainer>;
@@ -46,6 +46,7 @@ class retainer
     BC_POP_WARNING()
 
 private:
+    // This is thread safe.
     std::shared_lock<std::shared_mutex> shared_lock_;
 };