Update blazesym snapshot and profile example #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the Rust examples we see a warning: > warning: some crates are on edition 2021 which defaults to > `resolver = "2"`, but virtual workspaces default to `resolver = "1"` > note: to keep the current resolver, specify `workspace.resolver = "1"` > in the workspace root's manifest > note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` > in the workspace root's manifest Fix it by switching to resolver 2. Signed-off-by: Daniel Müller <deso@posteo.net>
Switch the profile example over to using Rust edition 2021 for the latest and greatest. Signed-off-by: Daniel Müller <deso@posteo.net>
Add the -v/--verbose option to control tracing of blazesym internals. Signed-off-by: Daniel Müller <deso@posteo.net>
|
Haven't gotten around to converting the C example... |
Update the clap dependency as used by the profile example to version 4.0, in order to not fall behind upstream too much. Signed-off-by: Daniel Müller <deso@posteo.net>
It is entirely possible for symbolization to fail for legitimate reasons when profiling the system continuously. For example, a process could terminate between the time addresses from it were captured and we attempt to symbolize them, in which case an error will be reported by blazesym. As it stands such an error will shoot down the profiler, which is not the desired behavior. With this change we handle such errors more gracefully by just printing an error message. Signed-off-by: Daniel Müller <deso@posteo.net>
Update the blazesym submodule to version 0.2.0-alpha.5. Also change the dependency to using the default features, which includes DWARF support and transparent symbol demangling. The profile example is overhauled to use the changed APIs and improve the code to be less redundant. Signed-off-by: Daniel Müller <deso@posteo.net>
danielocfb
force-pushed
the
topic/blazesym
branch
from
49bdf17
to
c86e4cc
Compare
danielocfb
force-pushed
the
topic/blazesym
branch
from
c86e4cc
to
8b6c950
Compare
Updated now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.