Option to parse a raw cookie string

libcpr · Sep 22, 2023 · a011366 · a011366
1 parent e341350
commit a011366
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 15 deletions.
diff --git a/cpr/util.cpp b/cpr/util.cpp
@@ -44,27 +44,31 @@ enum class CurlHTTPCookieField : size_t {
 };
 
 Cookies parseCookies(curl_slist* raw_cookies) {
-    const int CURL_HTTP_COOKIE_SIZE = static_cast<int>(CurlHTTPCookieField::Value) + 1;
     Cookies cookies;
     for (curl_slist* nc = raw_cookies; nc; nc = nc->next) {
-        std::vector<std::string> tokens = cpr::util::split(nc->data, '\t');
-        while (tokens.size() < CURL_HTTP_COOKIE_SIZE) {
-            tokens.emplace_back("");
-        }
-        const std::time_t expires = static_cast<time_t>(std::stoul(tokens.at(static_cast<size_t>(CurlHTTPCookieField::Expires))));
-        cookies.emplace_back(Cookie{
-                tokens.at(static_cast<size_t>(CurlHTTPCookieField::Name)),
-                tokens.at(static_cast<size_t>(CurlHTTPCookieField::Value)),
-                tokens.at(static_cast<size_t>(CurlHTTPCookieField::Domain)),
-                isTrue(tokens.at(static_cast<size_t>(CurlHTTPCookieField::IncludeSubdomains))),
-                tokens.at(static_cast<size_t>(CurlHTTPCookieField::Path)),
-                isTrue(tokens.at(static_cast<size_t>(CurlHTTPCookieField::HttpsOnly))),
-                std::chrono::system_clock::from_time_t(expires),
-        });
+        cookies.emplace_back(parseCookie(nc->data));
     }
     return cookies;
 }
 
+Cookie parseCookie(const std::string& raw_cookie) {
+    static const int CURL_HTTP_COOKIE_SIZE = static_cast<int>(CurlHTTPCookieField::Value) + 1;
+    std::vector<std::string> tokens = cpr::util::split(raw_cookie, '\t');
+    while (tokens.size() < CURL_HTTP_COOKIE_SIZE) {
+        tokens.emplace_back("");
+    }
+    const std::time_t expires = static_cast<time_t>(std::stoul(tokens.at(static_cast<size_t>(CurlHTTPCookieField::Expires))));
+    return Cookie{
+            tokens.at(static_cast<size_t>(CurlHTTPCookieField::Name)),
+            tokens.at(static_cast<size_t>(CurlHTTPCookieField::Value)),
+            tokens.at(static_cast<size_t>(CurlHTTPCookieField::Domain)),
+            isTrue(tokens.at(static_cast<size_t>(CurlHTTPCookieField::IncludeSubdomains))),
+            tokens.at(static_cast<size_t>(CurlHTTPCookieField::Path)),
+            isTrue(tokens.at(static_cast<size_t>(CurlHTTPCookieField::HttpsOnly))),
+            std::chrono::system_clock::from_time_t(expires),
+    };
+}
+
 Header parseHeader(const std::string& headers, std::string* status_line, std::string* reason) {
     Header header;
     std::vector<std::string> lines;

diff --git a/include/cpr/util.h b/include/cpr/util.h
@@ -14,6 +14,7 @@ namespace cpr::util {
 
 Header parseHeader(const std::string& headers, std::string* status_line = nullptr, std::string* reason = nullptr);
 Cookies parseCookies(curl_slist* raw_cookies);
+Cookie parseCookie(const std::string& raw_cookie);
 size_t readUserFunction(char* ptr, size_t size, size_t nitems, const ReadCallback* read);
 size_t headerUserFunction(char* ptr, size_t size, size_t nmemb, const HeaderCallback* header);
 size_t writeFunction(char* ptr, size_t size, size_t nmemb, std::string* data);