Made Session not movable any more

Why? cpr::Session is a complex object and while moving one has to keep all properties in mind. An easier solution would be to wrap cpr::Session inside for example a std::shared_ptr.
libcpr · Dec 26, 2023 · fa9d8d4 · fa9d8d4
1 parent 561db4f
commit fa9d8d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/cpr/session.h b/include/cpr/session.h
@@ -54,11 +54,11 @@ class Session : public std::enable_shared_from_this<Session> {
   public:
     Session();
     Session(const Session& other) = delete;
-    Session(Session&& old) = default;
+    Session(Session&& old) = delete;
 
     ~Session() = default;
 
-    Session& operator=(Session&& old) noexcept = default;
+    Session& operator=(Session&& old) noexcept = delete;
     Session& operator=(const Session& other) = delete;
 
     void SetUrl(const Url& url);

diff --git a/test/session_tests.cpp b/test/session_tests.cpp
@@ -1587,11 +1587,11 @@ TEST(CallbackTests, Move) {
     auto session = Session();
     session.SetDebugCallback(DebugCallback([](auto, auto, auto) {}));
 
-    auto use = +[](Session s) {
+    auto use = +[](Session& s) {
         s.SetUrl(server->GetBaseUrl());
         s.Get();
     };
-    use(std::move(session));
+    use(session);
 }