Refactored timeout.h: added template ctr and removed redundant ctrs (#1129)
#1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laxerhd
changed the title
Refactored timeout.h: added template ctr and removed redundant ctrs (#1129)
COM8
requested changes
Oct 27, 2024
README.md
Outdated
| @@ -7,7 +7,7 @@ | |||
| ## Announcements | |||
|
|
|||
| * This project is being maintained by [Fabian Sauter](https://github.com/com8) and [Kilian Traub](https://github.com/KingKili). | |||
| * For quick help, and discussion libcpr also offer a [gitter](https://gitter.im/libcpr/community?utm_source=share-link&utm_medium=link&utm_campaign=share-link) chat. | |||
| * For quick help, and discussion libcpr also offers a [gitter](https://gitter.im/libcpr/community?utm_source=share-link&utm_medium=link&utm_campaign=share-link) chat. | |||
There was a problem hiding this comment.
This stuff should not be included. As the other PR is now merged, try rebasing on the latest master or drop the commit if possible.
There was a problem hiding this comment.
Sorry, was a mistake on my side, I didn't want to include it here...
|
The latest commit should now be dropped. |
COM8
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Approved. Thanks.
To answer your question:
The NOLINT is still required since else clang-tidy will complain we should add explicit in front of the ctr to prevent an C++ offering an implicit cast from a Chrono duration to a timeout.
But in this case we want an implicit conversation to be possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the constructors of the
Timeoutclass:std::chrono::durationtype and converts it tostd::chrono::millisecondsmillisecondsandsecondsint32_twas untouchedI am not sure if we still want the
NOLINTNEXTLINE(...)above the template ctr, but for consistency I have added it back.Fixes #1129.