Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dangling reference to callback after move #962

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix dangling reference to callback after move #962

merged 1 commit into from
Sep 14, 2023

Conversation

kone-tlammi
Copy link
Contributor

@kone-tlammi kone-tlammi commented Sep 14, 2023 •
edited
Loading

I initially tried a wrapper object for the callbacks but callbacks have dependencies between each others so a unique_ptr
was much simpler.

@COM8 COM8 added the Bug 🐛 label Sep 14, 2023
@COM8 COM8 self-requested a review September 14, 2023 17:17
@COM8 COM8 self-assigned this Sep 14, 2023
COM8
COM8 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks @kone-tlammi !

@COM8 COM8 merged commit 99e3e23 into libcpr:master Sep 14, 2023
51 of 53 checks passed
@kone-tlammi kone-tlammi mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@COM8 COM8 COM8 approved these changes

Assignees

@COM8 COM8

Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kone-tlammi @COM8