Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPython 3.13 to CI when released (tracker issue) #152

Closed
neutrinoceros opened this issue Jun 24, 2024 · 3 comments
Closed

Add CPython 3.13 to CI when released (tracker issue) #152

neutrinoceros opened this issue Jun 24, 2024 · 3 comments

Comments

@neutrinoceros
Copy link
Contributor

neutrinoceros commented Jun 24, 2024

I ran some experiments on my fork to test pyerfa against CPython 3.13. I report that current wheels are already compatible with the GIL-enabled build for 3.13.0b2 (which is expected with abi3 wheels, restricted to Python's limited API).
update: #153

However, the free-threaded build isn't compatible yet. Attempting to build pyerfa will explicitly fail with the following error

In file included from erfa/ufunc.c:14:
        /opt/_internal/cpython-3.13.0b1-nogil/include/python3.13t/Python.h:51:4: error: #error "The limited API is not currently supported in the free-threaded build"

Here's the upstream issue to wait on before we can move forward python/cpython#111506

@neutrinoceros
Copy link
Contributor Author

Update:
python/cpython#111506 (comment) clarifies that free-threading + limited-api compatibility will not land in Python 3.13. I suspect we might want to start experimenting with astropy sooner than 3.14.0b1, so I'm now looking for a way to disable limited-api at build time (it should still be on by default) so we can at least build pyerfa from source with free-threading whenever we're ready for it.

@neutrinoceros
Copy link
Contributor Author

This issue should be closed when CPython 3.13 (final) is added to regular CI.

@mhvk mhvk changed the title CPython 3.13 support (tracker issue) Add CPython 3.13 to CI when released (tracker issue) Aug 23, 2024
@mhvk
Copy link
Contributor

mhvk commented Sep 15, 2024

I think #160 was the last bit in adding CPython 3.13 support, so closing this.

@mhvk mhvk closed this as completed Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants