Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom build requirements for Python 3.12 #113

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 20, 2023

Just to see what happens.

Blocked by:

@pllim

This comment was marked as resolved.

@pllim pllim mentioned this pull request Sep 20, 2023
@avalentino
Copy link
Member

Wait, what? I didn't even touch setuptools_scm stuff, though your version logic is kinda complicated in setup.py; is that really necessary?

It is to enforce the versioning scheme that always preserves the C ERFA version.
The implementation is indeed quite complicated but at the time I didn't manage to do better.
Any suggestion/patch is very welcome of course.

@pllim
Copy link
Contributor Author

pllim commented Sep 20, 2023

Any suggestion/patch is very welcome of course.

I am not well-versed in version generation. But the failure is blocking downstream testing over at astropy given that you do not publish a dev wheel (#109). I was just going to brute force to remove the logic and let setuptools_scm do its thing.

Either that or you will have to pin setuptools_scm<8 (https://pypi.org/project/setuptools-scm/#history) which is also not ideal.

@avalentino
Copy link
Member

Either that or you will have to pin setuptools_scm<8 (https://pypi.org/project/setuptools-scm/#history) which is also not ideal.

Probably at the moment it is the fastest solution, at least for the short term.
I will try to look into the issue during the week-end but I cannot guarantee, this is a very busy period for me.

now that numpy 1.26 is released.
@pllim pllim marked this pull request as ready for review September 20, 2023 19:08
@pllim
Copy link
Contributor Author

pllim commented Sep 20, 2023

This is ready for review. Thanks!

@avalentino
Copy link
Member

Thanks @pllim , amazing job! :)

@avalentino avalentino merged commit b5f2e18 into liberfa:master Sep 22, 2023
41 checks passed
@pllim pllim deleted the patch-1 branch September 22, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants