Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom build requirements for Python 3.12 #113

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Remove custom build requirements for Python 3.12 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27bdc0
Remove custom build requirements for Python 3.12
pllim Sep 20, 2023
b02fb1f
BLD: Remove temporary workaround for py312
pllim Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 6 additions & 29 deletions .github/workflows/ci_workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,57 +129,34 @@ jobs:
- cp39-manylinux_x86_64
- cp310-manylinux_x86_64
- cp311-manylinux_x86_64
- cp312-manylinux_x86_64
- cp39-musllinux_x86_64
- cp310-musllinux_x86_64
- cp311-musllinux_x86_64
- cp312-musllinux_x86_64
- cp39-manylinux_aarch64
- cp310-manylinux_aarch64
- cp311-manylinux_aarch64
- cp312-manylinux_aarch64
# MacOS X wheels - we deliberately do not build universal2 wheels.
# Note that the arm64 wheels are not actually tested so we
# rely on local manual testing of these to make sure they are ok.
- cp39*macosx_x86_64
- cp310*macosx_x86_64
- cp311*macosx_x86_64
- cp312*macosx_x86_64
- cp39*macosx_arm64
- cp310*macosx_arm64
- cp311*macosx_arm64
- cp312*macosx_arm64
# Windows wheels
- cp39*win32
- cp310*win32
- cp311*win32
- cp312*win32
- cp39*win_amd64
- cp310*win_amd64
- cp311*win_amd64
secrets:
pypi_token: ${{ secrets.pypi_token }}

# TEMPORARY WORKAROUND: Have to separate this out to use unreleased NumPy for Python 3.12
# because shell command to conditionally set PIP_PRE is broken in OpenAstronomy/github-actions-workflows
# https://github.com/OpenAstronomy/github-actions-workflows/issues/152
build_and_publish_py312:

uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish.yml@v1
with:
upload_to_pypi: ${{ startsWith(github.ref, 'refs/tags/v') && !endsWith(github.ref, '.dev') }}
test_extras: test
test_command: pytest --pyargs erfa
targets: |
# Linux wheels
- cp312-manylinux_x86_64
- cp312-musllinux_x86_64
- cp312-manylinux_aarch64
# MacOS X wheels - we deliberately do not build universal2 wheels.
# Note that the arm64 wheels are not actually tested so we
# rely on local manual testing of these to make sure they are ok.
- cp312*macosx_x86_64
- cp312*macosx_arm64
# No NumPy wheel for win32
#- cp312*win32
- cp312*win_amd64
# Required so that cp312 can grab a pre-release numpy.
# Can remove when cp312 is released.
env: |
CIBW_ENVIRONMENT: PIP_PRE=1
secrets:
pypi_token: ${{ secrets.pypi_token }}
7 changes: 1 addition & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ requires = [
"setuptools",
"setuptools_scm>=6.2,<8",
"jinja2>=2.10.3",
"numpy>=1.25,<2; python_version<'3.12'",

# For Python versions which aren't yet officially supported, we specify an
# unpinned NumPy which allows source distributions to be used and allows
# wheels to be used as soon as they become available.
"numpy>=1.26.0b1; python_version>='3.12'"
"numpy>=1.25,<2"
]
build-backend = 'setuptools.build_meta'
Loading