Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMP: Pin setuptools_scm<8 #115

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 20, 2023

Until compatibility with setuptools_scm 8 can be fixed properly (#116).

@pllim
Copy link
Contributor Author

pllim commented Sep 20, 2023

@avalentino , any chance this can get merged soon to unblock astropy testing? Thanks!

@avalentino avalentino added the dependencies Pull requests that update a dependency file label Sep 20, 2023
@avalentino
Copy link
Member

Thanks a lot @pllim

@avalentino , any chance this can get merged soon to unblock astropy testing? Thanks!

I have approved the PR but it is still in DRAFT.
Please change the status to "Ready for review" or just confirm that it is OK if I do it myself

@pllim pllim marked this pull request as ready for review September 20, 2023 17:24
@pllim
Copy link
Contributor Author

pllim commented Sep 20, 2023

Ooops. Done. Thanks!

@avalentino avalentino merged commit b6a7b21 into liberfa:master Sep 20, 2023
43 checks passed
@pllim pllim deleted the fix-setuptools-scm branch September 20, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants