Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test nightly wheels against CPython 3.13 (GIL flavor) #153

Closed
wants to merge 1 commit into from

Conversation

neutrinoceros
Copy link
Contributor

As I mentionned in #152, there are no incompatibilities with Python 3.13.0b2 at the moment, but enabling continuous testing will help consolidate the same effort in astropy.

@neutrinoceros neutrinoceros changed the title TST: test wheels against CPython 3.13 (GIL flavor) TST: test nightly wheels against CPython 3.13 (GIL flavor) Jun 24, 2024
@mhvk
Copy link
Contributor

mhvk commented Aug 12, 2024

Not quite sure about this: isn't it good enough to test via astropy? (I'm wondering a bit more generally why we would need a test of this every day, it is not like there are that many changes to pyerfa!)

@neutrinoceros
Copy link
Contributor Author

Well, maybe this workflow is really satisfying two othogonal needs: regular testing and producing nightlies.
I agree that the latter doesn't really need to happen daily nightly, given the slow development pace: maybe we should instead push a new batch only on merge ?
Regular testing on the other hand I think is important to keep: sure, pyerfa doesn't move much, but numpy does, and when something affects astropy, it's always nice to immediately know whether this package is also affected or not. That said, maybe daily testing is a bit too much still. How about going weekly ?

This particular PR shouldn't be merged as is now: upstream changes have made it at least partially redundant. Let me draft this for now. I'll revisit soon.

@neutrinoceros neutrinoceros marked this pull request as draft August 13, 2024 07:14
@mhvk
Copy link
Contributor

mhvk commented Aug 13, 2024

Yes, weekly may be a good compromise.

@neutrinoceros
Copy link
Contributor Author

For posterity, this is done in #157

@neutrinoceros
Copy link
Contributor Author

Now that numpy has cp313 wheels, this is completely unnecessary. Closing now.

@neutrinoceros neutrinoceros deleted the tst/cp313 branch August 21, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants